Skip to content

Only compare header size vs. max allowed frame size if the latter is limited #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

Only compare header size vs. max allowed frame size if the latter is limited #408

merged 1 commit into from
Sep 19, 2018

Conversation

michaelklishin
Copy link
Contributor

Proposed Changes

See #407 for context.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Header size exception when frame max is negotiated to 0 #407)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #407, references #362.
[#160628331]

@michaelklishin michaelklishin merged commit 1bc7248 into master Sep 19, 2018
@michaelklishin michaelklishin deleted the rabbitmq-java-client-407 branch September 19, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header size exception when frame max is negotiated to 0
1 participant
@michaelklishin